You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2009/03/12 10:34:55 UTC
[jira] Created: (HAMA-170) Implementation of DenseMatrix.Norm
Implementation of DenseMatrix.Norm
----------------------------------
Key: HAMA-170
URL: https://issues.apache.org/jira/browse/HAMA-170
Project: Hama
Issue Type: Improvement
Components: implementation
Affects Versions: 0.1.0
Reporter: Edward J. Yoon
Fix For: 0.1.0
enum Norm {
/** Maximum absolute row sum */
One,
/** The root of sum of the sum of squares */
Frobenius,
/** Largest entry in absolute value */
Infinity,
/** Largest entry in absolute value. Not a proper matrix norm */
Maxvalue
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-170) Implementation of Matrix.Norm
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708022#action_12708022 ]
Hudson commented on HAMA-170:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407772/HAMA-170.patch
against trunk revision 769288.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 9 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/173/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/173/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/173/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/173/console
This message is automatically generated.
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-170.patch
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HAMA-170) Implementation of DenseMatrix.Norm
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-170:
-----------------------------------
Assignee: Edward J. Yoon
> Implementation of DenseMatrix.Norm
> ----------------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-170) Implementation of Matrix.Norm
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-170:
--------------------------------
Summary: Implementation of Matrix.Norm (was: Implementation of DenseMatrix.Norm)
Will be applied to sparse matrix, too.
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-170) Implementation of Matrix.Norm
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-170:
----------------------------
Attachment: HAMA-170.patch
Attach my patch.
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-170.patch
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-170) Implementation of Matrix.Norm
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707754#action_12707754 ]
Samuel Guo commented on HAMA-170:
---------------------------------
hmm, I think the NormMapper, NormReducer code in Hama has implemented Norm-inf not Norm-1.
I will fixed it during implementing other norm methods.
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-170) Implementation of Matrix.Norm
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707294#action_12707294 ]
Edward J. Yoon commented on HAMA-170:
-------------------------------------
Oh, Thanks.
As you said, "The 1-norm is obtained by finding the sum of the absolute value of all the elements in each column of the matrix. The largest of these sums is the 1-norm. In mathematical terms, the 1-norm is simply the maximum absolute column sum of the matrix."
So, if A = {{1, 3}, {2, 4}} then ||A||1 = max(3, 7) = 7
Comments should be fixed. But, fortunately 1-Norm was correctly implemented as below.
1-NormMapper:
for(Map.Entry<Writable, Writable> e : value.entrySet()) {
rowSum += Math.abs(((DoubleEntry) e.getValue()).getValue());
}
1-NormReducer:
while (values.hasNext()) {
max = Math.max(values.next().get(), max);
}
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-170) Implementation of Matrix.Norm
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707290#action_12707290 ]
Samuel Guo commented on HAMA-170:
---------------------------------
Edward, It seems that you mis-understand Norm-1 and Norm-inf.
'Norm-1' is simply the maximum absolute column sum of the matrix
'Norm-inf' is simply the maximum absolute row sum of the matrix
Plz check the wikipedia: http://en.wikipedia.org/wiki/Matrix_norm
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-170) Implementation of Matrix.Norm
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707858#action_12707858 ]
Edward J. Yoon commented on HAMA-170:
-------------------------------------
Oh, sorry. You're right. Norm-inf and Norm-1 should be changed.
>> I will fixed it during implementing other norm methods.
Thanks. ;)
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.1.0
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-170) Implementation of Matrix.Norm
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708026#action_12708026 ]
Edward J. Yoon commented on HAMA-170:
-------------------------------------
Great.
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-170.patch
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-170) Implementation of Matrix.Norm
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-170:
----------------------------
Assignee: Samuel Guo (was: Edward J. Yoon)
Status: Patch Available (was: Open)
try it.
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-170.patch
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-170) Implementation of Matrix.Norm
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-170:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
just commit it.
> Implementation of Matrix.Norm
> -----------------------------
>
> Key: HAMA-170
> URL: https://issues.apache.org/jira/browse/HAMA-170
> Project: Hama
> Issue Type: Improvement
> Components: implementation
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Assignee: Samuel Guo
> Fix For: 0.1.0
>
> Attachments: HAMA-170.patch
>
>
> enum Norm {
> /** Maximum absolute row sum */
> One,
> /** The root of sum of the sum of squares */
> Frobenius,
>
> /** Largest entry in absolute value */
> Infinity,
>
> /** Largest entry in absolute value. Not a proper matrix norm */
> Maxvalue
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.