You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@myfaces.apache.org by aw...@apache.org on 2007/08/14 18:23:47 UTC

svn commit: r565822 - /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageBoxRenderer.java

Author: awiner
Date: Tue Aug 14 09:23:43 2007
New Revision: 565822

URL: http://svn.apache.org/viewvc?view=rev&rev=565822
Log:
TRINIDAD-624: af:messages generates improper style attribute by default

Modified:
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageBoxRenderer.java

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageBoxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageBoxRenderer.java?view=diff&rev=565822&r1=565821&r2=565822
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageBoxRenderer.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageBoxRenderer.java Tue Aug 14 09:23:43 2007
@@ -423,8 +423,12 @@
       if (hasMessages)
         return inlineStyle;
       
-      // Ensure the MessageBox is hidden for inline mode when there are no messages
-      return inlineStyle + ";display:none;";
+      // Ensure the MessageBox is hidden for inline mode when
+      // there are no messages
+      if (inlineStyle == null)
+        return "display:none";
+      else
+        return inlineStyle + ";display:none";
     }
     
     @Override