You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by tzezula <gi...@git.apache.org> on 2016/03/03 13:47:58 UTC
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
GitHub user tzezula opened a pull request:
https://github.com/apache/ant/pull/15
Added JDK 9 module system support to the Java Task
Added main module, modulepath and moduleupgradepath into Java task.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzezula/ant jigsaw/java
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit dd8b5f45ddc0d1693ab7132c14f02e2d2d09c850
Author: Tomas Zezula <to...@gmail.com>
Date: 2016-03-03T11:56:40Z
Added module, modulepath attributes and modulepath, moduleupgradepath elements into Java task.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-192878534
Thanks a lot Tomas, I've merged your patch.
It would be good if you could also provide a patch the java task page inside of Ant's manual.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by tzezula <gi...@git.apache.org>.
Github user tzezula commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-195935714
Thanks a lot Stefan!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-195781492
I had a few merge conflicts as I already added the since tags, but I think I've got them resolved.
Many thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-192895174
don't worry and thanks for your support
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-192893331
Great.
Our [CI builds](https://builds.apache.org/job/Ant-Build-Matrix/) on Windows are failing because the test `testModuleAndClassnameCommandLine` expects the module to be `TestModule/org.apache.Test` while in fact it is `TestModule\org.apache.Test`. Before I start fixing the code, am I correct in assuming the separator between module and classname always is a forward slash? I'm having a hard time finding any documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by tzezula <gi...@git.apache.org>.
Github user tzezula commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-193997234
Hi Stefan
Here is a patch for the Java task page inside of Ant's manual. I've also updated the since tags to 1.9.7:
https://github.com/tzezula/ant/commit/aef407be4d33de09861a1f9677b2f15ea5ea8fdf
I've added a modulepathref attribute to the Java task to be symmetric with classpath:
https://github.com/tzezula/ant/commit/1e501f27ecc8f292ff028191e886a36d4b571d79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by tzezula <gi...@git.apache.org>.
Github user tzezula commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-192890123
Thanks Stefan, I will do a patch of Ant's java task manual.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...
Posted by tzezula <gi...@git.apache.org>.
Github user tzezula commented on the pull request:
https://github.com/apache/ant/pull/15#issuecomment-192894935
Sorry for that. I will get some Windows box for testing.
Yes, it's '/'.
The -m option support either <modulename> or <modulename>/<mainclass>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org