You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Kevan Miller (JIRA)" <ji...@apache.org> on 2009/05/26 04:19:46 UTC
[jira] Created: (GERONIMO-4646) Warn during a war deployment, if no
WEB-INF/web.xml file is found
Warn during a war deployment, if no WEB-INF/web.xml file is found
-----------------------------------------------------------------
Key: GERONIMO-4646
URL: https://issues.apache.org/jira/browse/GERONIMO-4646
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Affects Versions: 2.1.4, 2.2
Reporter: Kevan Miller
Fix For: 2.1.5, 2.2
Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4646) Warn during a war deployment, if no
WEB-INF/web.xml file is found
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-4646.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.1.5)
2.2 rev 830415. Not fixed in 2.1.5. Not appropriate for trunk since 3.0 encourages annotations instead of web.xml.
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
> Key: GERONIMO-4646
> URL: https://issues.apache.org/jira/browse/GERONIMO-4646
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.2
>
> Attachments: GERONIMO-4646 2.patch, GERONIMO-4646 2.patch, GERONIMO-4646.patch, GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4646) Warn during a war deployment, if
no WEB-INF/web.xml file is found
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743088#action_12743088 ]
Ivan commented on GERONIMO-4646:
--------------------------------
Hi, Victor
Exception is a big collection of many type exceptions, sometimes, maybe other exceptions are thrown in the try block, and they are catched by the Exception handler.
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
> Key: GERONIMO-4646
> URL: https://issues.apache.org/jira/browse/GERONIMO-4646
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4646.patch, GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (GERONIMO-4646) Warn during a war
deployment, if no WEB-INF/web.xml file is found
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739321#action_12739321 ]
Rex Wang edited comment on GERONIMO-4646 at 8/4/09 7:57 PM:
------------------------------------------------------------
Hi Victor, just have a look at your patch, I think you should not provide the same warning message as the missing geronimo-web.xml:
+ log.warn("Web application " + targetPath + " does not contain a WEB-INF/web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.");
The web.xml is not a geronimo deployment plan, so you can not give the deployer a separate web.xml file on anywhere..
-Rex
was (Author: rwonly):
Hi Victor, just have a look at your patch, I think you should not provide the same warning message as the missing geronimo-web.xml:
+ log.warn("Web application " + targetPath + " does not contain a WEB-INF/web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.");
The web.xml is not a geronimo deployment plan, so you can not give the deployer a separate deployment plan file on anywhere..
-Rex
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
> Key: GERONIMO-4646
> URL: https://issues.apache.org/jira/browse/GERONIMO-4646
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4646) Warn during a war deployment, if no
WEB-INF/web.xml file is found
Posted by "Victor Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Fang updated GERONIMO-4646:
----------------------------------
Attachment: GERONIMO-4646 2.patch
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
> Key: GERONIMO-4646
> URL: https://issues.apache.org/jira/browse/GERONIMO-4646
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4646 2.patch, GERONIMO-4646 2.patch, GERONIMO-4646.patch, GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4646) Warn during a war deployment, if
no WEB-INF/web.xml file is found
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739321#action_12739321 ]
Rex Wang commented on GERONIMO-4646:
------------------------------------
Hi Victor, just have a look at your patch, I think you should not provide the same warning message as the missing geronimo-web.xml:
+ log.warn("Web application " + targetPath + " does not contain a WEB-INF/web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.");
The web.xml is not a geronimo deployment plan, so you can not give the deployer a separate deployment plan file on anywhere..
-Rex
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
> Key: GERONIMO-4646
> URL: https://issues.apache.org/jira/browse/GERONIMO-4646
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4646) Warn during a war deployment, if no
WEB-INF/web.xml file is found
Posted by "Victor Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Fang updated GERONIMO-4646:
----------------------------------
Attachment: GERONIMO-4646.patch
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
> Key: GERONIMO-4646
> URL: https://issues.apache.org/jira/browse/GERONIMO-4646
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4646.patch, GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4646) Warn during a war deployment, if no
WEB-INF/web.xml file is found
Posted by "Victor Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Fang updated GERONIMO-4646:
----------------------------------
Attachment: GERONIMO-4646.PNG
GERONIMO-4646.patch
> Warn during a war deployment, if no WEB-INF/web.xml file is found
> -----------------------------------------------------------------
>
> Key: GERONIMO-4646
> URL: https://issues.apache.org/jira/browse/GERONIMO-4646
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.1.5, 2.2
>
> Attachments: GERONIMO-4646.patch, GERONIMO-4646.PNG
>
>
> Per the specs, a WAR without a WEB-INF/web.xml is a valid WAR file. However, it's also an indication of a poorly formatted WAR. It seems like it would be useful to log a warning, if we don't find a WEB-INF/web.xml file, just like we log a WARN, if a geronimo-web.xml file is not found:
> 2009-05-25 22:13:12,535 WARN [TomcatModuleBuilder] Web application . does not contain a WEB-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depending on whether you have things like resource references that need to be resolved. You can also give the deployer a separate deployment plan file on the command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.