[jira] [Commented] (LUCENE-6306) Merging of doc values, norms is not abortable

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339940#comment-14339940 ] 

Michael McCandless commented on LUCENE-6306:
--------------------------------------------

This is low risk ... I think we should fix for 4.10.4.

> Merging of doc values, norms is not abortable
> ---------------------------------------------
>
>                 Key: LUCENE-6306
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6306
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Blocker
>             Fix For: 4.10.4
>
>         Attachments: LUCENE-6306.patch
>
>
> When you call IW.rollback, IW asks all running merges to abort, and the merges should periodically check their abort flags (it's a "cooperative" mechanism, like thread interrupting in Java).
> In 5.x/trunk we have a nice clean solution where the Directory checks the abort bit during writes, so the codec doesn't have to bother with this.
> But in 4.x, we have to call MergeState.checkAbort.work, and I noticed that neither DVs nor norms call this.
> Typically this is not a problem since merging DVs and norms is usually fast, but for a very large merge / very many DVs and norm'd fields, it could take non-trivial time to merge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org