[GitHub] [helix] narendly commented on a change in pull request #886: Standardize the logging message format in ClusterAccessor and ConfigAccessor

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #886: Standardize the logging message format in ClusterAccessor and ConfigAccessor
URL: https://github.com/apache/helix/pull/886#discussion_r391243697
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
 ##########
 @@ -44,6 +44,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+
 
 Review comment:
   Thanks for doing this! 
   
   1. Does this include the new endpoints?
   2. LOG is the convention we use throughout our codebase. Could you also quickly change logger's to LOG? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org