[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #7738: [Bug] [dolphinscheduler-server] process instance is always running: task is failure when process instance FailureStrategy.END #7698

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #7738:
URL: https://github.com/apache/dolphinscheduler/pull/7738#discussion_r776673742



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/queue/TaskResponsePersistThread.java
##########
@@ -146,6 +146,9 @@ private boolean persist(TaskResponseEvent taskResponseEvent) {
                     channel.writeAndFlush(taskResponseCommand.convert2Command());
                 }
                 break;
+            case ACTION_STOP:
+                logger.debug("ACTION_STOP: task instance id:{}, process instance id:{}", taskResponseEvent.getTaskInstanceId(), taskResponseEvent.getProcessInstanceId());

Review comment:
       It seems that it should handle stop event here.

##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1227,12 +1235,11 @@ private void killAllTasks() {
             ITaskProcessor taskProcessor = activeTaskProcessorMaps.get(taskId);
             taskProcessor.action(TaskAction.STOP);
             if (taskProcessor.taskState().typeIsFinished()) {
-                StateEvent stateEvent = new StateEvent();
-                stateEvent.setType(StateEventType.TASK_STATE_CHANGE);

Review comment:
       Is it OK to remove the `TASK_STATE_CHANGE`  event?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org