You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2015/05/08 14:28:21 UTC
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/128
CB-8992 Do not install mobilespec tests when --plugins specified
https://issues.apache.org/jira/browse/CB-8992
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-mobile-spec CB-8992
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit aeb5e30a063d775744098e99b3c03d82c84af46d
Author: alsorokin <al...@akvelon.com>
Date: 2015-05-08T12:26:22Z
CB-8992 Do not install mobilespec tests when --plugins specified
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100798943
Thanks for the comments, Dmitry. I've addressed them and updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100320977
Why not install the mobilespec tests when the plugin is installed? Why is this undesired behaviour?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100219011
:1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100384365
Ok. Sounds reasonable. I left some comments in review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100331390
If I explicitly specify list of plugins to be tested I don't want to run org.apache.cordova.mobilespec.tests (they represent some extra tests not related to our plugins like iframe, XHR, etc)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981911
--- Diff: createmobilespec/createmobilespec.js ---
@@ -546,11 +547,12 @@ function installPlugins() {
console.log("Installing local test framework plugins...");
var linkPluginsFlag = (argv.link || argv.linkplugins) ? ' --link' : '';
- pluginAdd('org.apache.cordova.mobilespec.tests', mobile_spec_git_dir, linkPluginsFlag + browserifyFlag);
+ if (!argv.plugins) {
--- End diff --
Please comment why this check is here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981882
--- Diff: createmobilespec/createmobilespec.js ---
@@ -56,7 +56,8 @@ function popd(dir) {
}
function pluginAdd(pluginName, searchPath, extraFlags) {
- var command = cli + ' plugin add ' + pluginName + ' --searchpath ' + searchPath;
+ var sp = SEARCH_PATHS.hasOwnProperty(pluginName) ? SEARCH_PATHS[pluginName] : searchPath;
--- End diff --
It's clearer to put this logic outside of the function, on [line 568] (https://github.com/apache/cordova-mobile-spec/pull/128/files#diff-ad19d116ad56f7b3ae8ee9fdc8733f69R568). That way pluginAdd is only concerned with adding a plugin from a given path, not with extra logic regarding the path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org