You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/10/18 23:05:53 UTC
[GitHub] [cordova-osx] raphinesse opened a new pull request #115: refactor: drop q
raphinesse opened a new pull request #115:
URL: https://github.com/apache/cordova-osx/pull/115
Depends on #114. Moves https://github.com/apache/cordova/issues/7 forward.
I tried to keep this minimal. So no smart refactoring or anything going on.
Best to review without showing space changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] raphinesse merged pull request #115: refactor!: drop q
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #115:
URL: https://github.com/apache/cordova-osx/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] erisu commented on pull request #115: refactor!: drop q
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #115:
URL: https://github.com/apache/cordova-osx/pull/115#issuecomment-947314449
You can probably submit a PR first to bump the version of `package.json` and `package-lock.json` to `7.0.0-dev` and then merge this in.
I am not aware of any plan for the next release. (patch, minor or major)
If we did release, I suspect everyone will expect M1 support, no matter what was released next. Preparing something like this might be a major change.
I dont see a near future release so might as well bump the version and merge it in so it doesn't remain open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] erisu edited a comment on pull request #115: refactor!: drop q
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #115:
URL: https://github.com/apache/cordova-osx/pull/115#issuecomment-947314449
You can probably submit a PR first to bump the version of `package.json` and `package-lock.json` to `7.0.0-dev` and then merge this in.
I am not aware of any plan for the next release. (patch, minor or major)
If we did release, I suspect everyone will expect M1 support, no matter what type of release. Preparing something like this might be a major change.
Since I do not see a near future release, it might be best to just go ahead and bump the version and merge this PR in so it doesnt remain open and go stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] raphinesse commented on pull request #115: refactor!: drop q
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #115:
URL: https://github.com/apache/cordova-osx/pull/115#issuecomment-947083959
Thanks for the review @erisu!
Since this PR might introduce slight changes in observed behavior (e.g. error handling in the binaries) and change the types of promises returned from public methods, this is probably major, right?
If so, should we merge it now anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org