[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24170: [SPARK-26998][CORE] Add secure alternatives of ssl password parameters

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #24170: [SPARK-26998][CORE] Add secure alternatives of ssl password parameters
URL: https://github.com/apache/spark/pull/24170#discussion_r268094329
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SSLOptions.scala
 ##########
 @@ -131,8 +132,9 @@ private[spark] case class SSLOptions(
   /** Returns a string representation of this SSLOptions with all the passwords masked. */
   override def toString: String = s"SSLOptions{enabled=$enabled, port=$port, " +
       s"keyStore=$keyStore, keyStorePassword=${keyStorePassword.map(_ => "xxx")}, " +
+      s"keyPassword=${keyPassword.map(_ => "xxx")}, keyStoreType=$keyStoreType, " +
 
 Review comment:
   Yeah, added to make it complete.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org