You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "glynnbird (via GitHub)" <gi...@apache.org> on 2023/01/26 14:13:21 UTC

[GitHub] [couchdb-nano] glynnbird opened a new pull request, #325: bring cookie handling in-house. Fixes issue #324

glynnbird opened a new pull request, #325:
URL: https://github.com/apache/couchdb-nano/pull/325

   ## Overview
   
   Fixes a bug in cookie parsing. See Issue #324. 
   
   ## Testing recommendations
   
   As well as the automated testing,  a long-running script to see if a session outlasts the first cookie:
   
   ```
   const Nano = require('.')
   const nano = Nano(process.env.COUCH_URL)
   
   const sleep = async (ms) => {
     return new Promise((resolve, reject) => {
       setTimeout(resolve, ms)
     })
   }
   const main = async () => {
     await nano.auth(process.env.COUCH_USER, process.env.COUCH_PASSWORD)
   
     do {
       const r = await nano.db.list()
       console.log(new Date().toISOString(), r.length)
       await sleep(30000)
     } while (1)
   }
   
   main()
   ```
   
   ## GitHub issue number
   
   Fixes Issue #324. 
   
   ## Related Pull Requests
   
   A provisional PR that replaces Axios already had code to bring cookie handling in-house, so this has been brought forward here. See https://github.com/apache/couchdb-nano/pull/314
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb-nano] glynnbird merged pull request #325: bring cookie handling in-house. Fixes issue #324

Posted by "glynnbird (via GitHub)" <gi...@apache.org>.
glynnbird merged PR #325:
URL: https://github.com/apache/couchdb-nano/pull/325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org