You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2005/09/27 14:44:52 UTC
[jira] Created: (JCR-225) LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
-----------------------------------------------------------------------------
Key: JCR-225
URL: http://issues.apache.org/jira/browse/JCR-225
Project: Jackrabbit
Type: Improvement
Components: locks
Reporter: angela
/**
* {@inheritDoc}
* <p/>
* When the owning session is logging out, we have to perform some
* operations depending on the lock type.
* (1) If the lock was session-scoped, we unlock the node.
* (2) If the lock was open-scoped, we remove the lock token
* from the session.
*/
public void loggingOut(SessionImpl session) {
if (live) {
if (sessionScoped) {
lockMgr.unlock(this);
} else {
if (session.equals(lockHolder)) {
lockHolder = null;
}
}
}
}
if (2) is true, the lockToken is not removed from the session (at least not within the method).
regards
angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-225) LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-225?page=all ]
Jukka Zitting updated JCR-225:
------------------------------
Fix Version: 1.0
> LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
> -----------------------------------------------------------------------------
>
> Key: JCR-225
> URL: http://issues.apache.org/jira/browse/JCR-225
> Project: Jackrabbit
> Type: Improvement
> Components: locks
> Reporter: angela
> Priority: Minor
> Fix For: 1.0
>
> /**
> * {@inheritDoc}
> * <p/>
> * When the owning session is logging out, we have to perform some
> * operations depending on the lock type.
> * (1) If the lock was session-scoped, we unlock the node.
> * (2) If the lock was open-scoped, we remove the lock token
> * from the session.
> */
> public void loggingOut(SessionImpl session) {
> if (live) {
> if (sessionScoped) {
> lockMgr.unlock(this);
> } else {
> if (session.equals(lockHolder)) {
> lockHolder = null;
> }
> }
> }
> }
> if (2) is true, the lockToken is not removed from the session (at least not within the method).
> regards
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-225) LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-225?page=comments#action_12357590 ]
angela commented on JCR-225:
----------------------------
since dominique is on vacation, briefly discussed this with stefan.
since Session.addLockToken, getLockTokens, removeLockTokens cannot throw and do not perform sanity-checks, we decided to remove the locktoken from the session.
hope that's ok.
regards
angela
> LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
> -----------------------------------------------------------------------------
>
> Key: JCR-225
> URL: http://issues.apache.org/jira/browse/JCR-225
> Project: Jackrabbit
> Type: Improvement
> Components: locks
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Fix For: 1.0
>
> /**
> * {@inheritDoc}
> * <p/>
> * When the owning session is logging out, we have to perform some
> * operations depending on the lock type.
> * (1) If the lock was session-scoped, we unlock the node.
> * (2) If the lock was open-scoped, we remove the lock token
> * from the session.
> */
> public void loggingOut(SessionImpl session) {
> if (live) {
> if (sessionScoped) {
> lockMgr.unlock(this);
> } else {
> if (session.equals(lockHolder)) {
> lockHolder = null;
> }
> }
> }
> }
> if (2) is true, the lockToken is not removed from the session (at least not within the method).
> regards
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (JCR-225) LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-225?page=all ]
angela reassigned JCR-225:
--------------------------
Assign To: angela
> LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
> -----------------------------------------------------------------------------
>
> Key: JCR-225
> URL: http://issues.apache.org/jira/browse/JCR-225
> Project: Jackrabbit
> Type: Improvement
> Components: locks
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Fix For: 1.0
>
> /**
> * {@inheritDoc}
> * <p/>
> * When the owning session is logging out, we have to perform some
> * operations depending on the lock type.
> * (1) If the lock was session-scoped, we unlock the node.
> * (2) If the lock was open-scoped, we remove the lock token
> * from the session.
> */
> public void loggingOut(SessionImpl session) {
> if (live) {
> if (sessionScoped) {
> lockMgr.unlock(this);
> } else {
> if (session.equals(lockHolder)) {
> lockHolder = null;
> }
> }
> }
> }
> if (2) is true, the lockToken is not removed from the session (at least not within the method).
> regards
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-225) LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-225?page=all ]
angela resolved JCR-225:
------------------------
Resolution: Fixed
fixed rev. 344124
> LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
> -----------------------------------------------------------------------------
>
> Key: JCR-225
> URL: http://issues.apache.org/jira/browse/JCR-225
> Project: Jackrabbit
> Type: Improvement
> Components: locks
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Fix For: 1.0
>
> /**
> * {@inheritDoc}
> * <p/>
> * When the owning session is logging out, we have to perform some
> * operations depending on the lock type.
> * (1) If the lock was session-scoped, we unlock the node.
> * (2) If the lock was open-scoped, we remove the lock token
> * from the session.
> */
> public void loggingOut(SessionImpl session) {
> if (live) {
> if (sessionScoped) {
> lockMgr.unlock(this);
> } else {
> if (session.equals(lockHolder)) {
> lockHolder = null;
> }
> }
> }
> }
> if (2) is true, the lockToken is not removed from the session (at least not within the method).
> regards
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-225) LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-225?page=all ]
Dominique Pfister updated JCR-225:
----------------------------------
Priority: Minor (was: Major)
This method is invoked at the time a session is logging out, that is, the session gets invalidated. The javadoc does not correspond to the actual implementation, of course, but the net effect is the same, since the session's lock token are no longer accessible. Therefore lowering priority.
> LockInfo.logginOut(SessionImpl): javadoc does not correspond to executed code
> -----------------------------------------------------------------------------
>
> Key: JCR-225
> URL: http://issues.apache.org/jira/browse/JCR-225
> Project: Jackrabbit
> Type: Improvement
> Components: locks
> Reporter: angela
> Priority: Minor
>
> /**
> * {@inheritDoc}
> * <p/>
> * When the owning session is logging out, we have to perform some
> * operations depending on the lock type.
> * (1) If the lock was session-scoped, we unlock the node.
> * (2) If the lock was open-scoped, we remove the lock token
> * from the session.
> */
> public void loggingOut(SessionImpl session) {
> if (live) {
> if (sessionScoped) {
> lockMgr.unlock(this);
> } else {
> if (session.equals(lockHolder)) {
> lockHolder = null;
> }
> }
> }
> }
> if (2) is true, the lockToken is not removed from the session (at least not within the method).
> regards
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira