You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2025/05/01 13:43:55 UTC

[I] Make `ManifestMetadata` V1 compliant [iceberg-rust]

Fokko opened a new issue, #1281:
URL: https://github.com/apache/iceberg-rust/issues/1281

   ### Apache Iceberg Rust version
   
   None
   
   ### Describe the bug
   
   I noticed that the ManifestMetadata has everything required:
   
   https://github.com/apache/iceberg-rust/blob/b4bc6dd15ae4f7a4b1c9ce555e3458089a83e228/crates/iceberg/src/spec/manifest/metadata.rs#L30-L42
   
   However, this is not the case for V1:
   
   ![Image](https://github.com/user-attachments/assets/fd26fa13-46d6-4a88-8a3b-fd2bde290526)
   
   I think `schema-id`, `partition-spec-id` and `file-format` should be optional. We can fill in `content` with `data` for V1 since that's the only option for V1.
   
   ### To Reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Willingness to contribute
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Make `ManifestMetadata` V1 compliant [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #1281:
URL: https://github.com/apache/iceberg-rust/issues/1281#issuecomment-2844935165

   Misread the code, looks good 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Make `ManifestMetadata` V1 compliant [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #1281: Make `ManifestMetadata` V1 compliant
URL: https://github.com/apache/iceberg-rust/issues/1281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org