[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #613: Minificpp 927 Nanofi tailfile delimited processor

[GitBox <gi...@apache.org>]

msharee9 commented on a change in pull request #613: Minificpp 927 Nanofi tailfile delimited processor
URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r304086842
 
 

 ##########
 File path: nanofi/include/api/ecu.h
 ##########
 @@ -0,0 +1,57 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+    *
+    *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+
+#ifndef NANOFI_INCLUDE_API_ECU_H_
+#define NANOFI_INCLUDE_API_ECU_H_
+
+#include <signal.h>
+#include "api/nanofi.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+extern nifi_instance * instance;
+extern standalone_processor * proc;
+extern flow_file_list * ff_list;
+extern uint64_t curr_offset;
 
 Review comment:
   Even though these are global variables, each instance of the ecu will have its own variable. Why do you think that these variables will cause any problem? I agree that having global variables like these is not a good practice and I will try to correct it but I think global variables will not cause any problem with one or multiple instances of same or different ecus.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services