You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "FangYongs (via GitHub)" <gi...@apache.org> on 2023/03/20 15:06:20 UTC

[GitHub] [flink] FangYongs opened a new pull request, #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

FangYongs opened a new pull request, #22227:
URL: https://github.com/apache/flink/pull/22227

   ## What is the purpose of the change
   
   There're .q files and script readers in client and gateway, which are quite similar. This PR aims to merge the .q files in gateway module and merge the two readers.
   
   ## Brief change log
     - Delete unused script reader
     - Merge .q files in sql client and gateway
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `CliClientITCase` and `AbstractSqlGatewayStatementITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no) no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
     - The serializers: (yes / no / don't know) no
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
     - The S3 file system connector: (yes / no / don't know) no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no) no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22227:
URL: https://github.com/apache/flink/pull/22227#issuecomment-1476417025

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9f45c13538ab75fbbd0d6b9238a92709ef2833bb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9f45c13538ab75fbbd0d6b9238a92709ef2833bb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9f45c13538ab75fbbd0d6b9238a92709ef2833bb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] FangYongs commented on pull request #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22227:
URL: https://github.com/apache/flink/pull/22227#issuecomment-1477305621

   @fsk119 Please help to review this PR when you are free, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org