You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2023/06/28 08:57:15 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request, #5020: Add codestart for camel-quarkus-kotlin
jamesnetherton opened a new pull request, #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020
POC of a basic Camel Quarkus codestart. I thought we could try it on a 'low traffic' extension initially and then evaluate expanding it to other extensions.
The codestart will bootstrap a project with some basic routes and a JVM mode test that leverages `CamelQuarkusTestSupport`.
Feedback is welcome. If we think this is worthwhile, I would need to make some tweaks to the `cq-maven-plugin` before this PR is merged, so that the codestart config is preserved in the extension metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #5020: Add codestart for camel-quarkus-kotlin
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020#discussion_r1296978602
##########
extensions/kotlin/deployment/src/test/kotlin/org/apache/camel/quarkus/kotlin/deployment/KotlinCodestartTest.kt:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.kotlin.deployment
+
+import io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartCatalog
+import io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest
+import org.junit.jupiter.api.Disabled
+import org.junit.jupiter.api.Test
+
+import org.junit.jupiter.api.extension.RegisterExtension
+
+class KotlinCodestartTest {
+
+ @Test
+ @Throws(Throwable::class)
+ fun testContent() {
+ Companion.codestartTest.checkGeneratedSource("org.acme.Routes")
+ }
+
+ @Disabled("https://github.com/quarkusio/quarkus/issues/34308")
Review Comment:
You seem to be the first ever to try this outside Quarkus :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add codestart for camel-quarkus-kotlin [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton closed pull request #5020: Add codestart for camel-quarkus-kotlin
URL: https://github.com/apache/camel-quarkus/pull/5020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add codestart for camel-quarkus-kotlin [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020#issuecomment-2063547204
I'll close this for now. I may revisit it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #5020: Add codestart for camel-quarkus-kotlin
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020#issuecomment-1682379316
> I don't think creating routes for specialized components is ever going to be achievable for a codestart. There could be multiple endpoint URI options required, CDI beans needed, configuration properties etc. I saw the initial goal as being able to bootstrap a simple app with a basic RouteBuilder, together with a test. It's for the user to deal with the specifics of their app.
Yes, so maybe it's just a code start for each DSL generating a basic route. And then maybe the generated route is run on ci during cq tests or alike.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #5020: Add codestart for camel-quarkus-kotlin
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020#issuecomment-1681899405
Nice experiment :+1: Might be interesting for very few select topics. Like, it could improve the very first experience for new CQ users.
On the other hand, we would need to take care at the maintenance cost. Like, how do we ensure that generated codestarts can run at each version without manual testing ?
There is also the question of how well codestart behaves when mixing multiple extensions as this the main scenario when building Camel integrations. Maybe we could integrate a single code start per DSL and that's all... Need a bit more thinking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #5020: Add codestart for camel-quarkus-kotlin
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020#issuecomment-1682000432
> how do we ensure that generated codestarts can run at each version without manual testing ?
There is a test called `KotlinCodestartTest` in this PR https://github.com/apache/camel-quarkus/pull/5020/files#diff-93ae7fb045df527f7bf6084da75695a312f6665471fe730534b8286594b96211
> There is also the question of how well codestart behaves when mixing multiple extensions as this the main scenario when building Camel integrations. Maybe we could integrate a single code start per DSL and that's all...
That's a valid concern. IIRC, it was mentioned very early when the CodeStarts were introduced that the composability might be an issue. OTOH, do our extensions really require amending some file provided by some other extension? Maybe application.properties? Otherwise each extension could provide its own route definition file in some particular DSL. Maybe for some extensions, it would be hard to write such without timer. But it would be easy for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #5020: Add codestart for camel-quarkus-kotlin
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020#issuecomment-1682312505
>> how do we ensure that generated codestarts can run at each version without manual testing ?
>
> There is a test called `KotlinCodestartTest` in this PR https://github.com/apache/camel-quarkus/pull/5020/files#diff-93ae7fb045df527f7bf6084da75695a312f6665471fe730534b8286594b96211
It looks like assertion that content is well generated. Does it also check that the generated code is runnable ?
> >There is also the question of how well codestart behaves when mixing multiple extensions as this the main scenario when building Camel integrations. Maybe we could integrate a single code start per DSL and that's all...
>
> That's a valid concern. IIRC, it was mentioned very early when the CodeStarts were introduced that the composability might be an issue. OTOH, do our extensions really require amending some file provided by some other extension? Maybe application.properties? Otherwise each extension could provide its own route definition file in some particular DSL. Maybe for some extensions, it would be hard to write such without timer. But it would be easy for others.
More than composability related technical issues that might be solved or not, there is the subject of how much it would make sense to code start multiple extensions together. Like code starting an app with jms + jdbc, what route does it make sense to generate from(timer).to(jms) + from(timer.to(jdbc) route ? from(jms).to(jdbc) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5020: Add codestart for camel-quarkus-kotlin
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5020:
URL: https://github.com/apache/camel-quarkus/pull/5020#issuecomment-1682344935
Thanks all for the feedback! I forgot I even opened this PR :stuck_out_tongue:
> It looks like assertion that content is well generated. Does it also check that the generated code is runnable ?
The test framework can run the tests in the generated project.
> There is also the question of how well codestart behaves when mixing multiple extensions
Yes, composability is a tricky problem. It needs more thought, but you can have quite complex logic in the codestart templates to help with that.
> Like code starting an app with jms + jdbc, what route does it make sense to generate from(timer).to(jms) + from(timer.to(jdbc) route ? from(jms).to(jdbc) ?
I don't think creating routes for specialized components is ever going to be achievable for a codestart. There could be multiple endpoint URI options required, CDI beans needed, configuration properties etc. I saw the initial goal as being able to bootstrap a simple app with a basic `RouteBuilder`, together with a test. It's for the user to deal with the specifics of their app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org