You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/19 16:57:20 UTC

[GitHub] [lucene-solr] HoustonPutman commented on pull request #2222: SOLR-14297: replace commons-codec Base64 with JDK8 Base64

HoustonPutman commented on pull request #2222:
URL: https://github.com/apache/lucene-solr/pull/2222#issuecomment-762977652


   Since Base64.Encoder and Base64.Decoder are thread-safe, it might be better to have static implementations of each for each class here, instead of generating one per request.
   
   Otherwise this looks pretty straightforward!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org