[GitHub] [incubator-openwhisk] tysonnorris commented on a change in pull request #4326: Invoker backpressure

[GitBox <gi...@apache.org>]

tysonnorris commented on a change in pull request #4326: Invoker backpressure
URL: https://github.com/apache/incubator-openwhisk/pull/4326#discussion_r298366276
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -195,8 +243,10 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
               // Add this request to the buffer, as it is not there yet.
               runBuffer = runBuffer.enqueue(r)
             }
-            // As this request is the first one in the buffer, try again to execute it.
-            self ! Run(r.action, r.msg, retryLogDeadline)
+            if (!poolConfig.clusterManagedResources) {
 
 Review comment:
   Agreed this seems wrong, just wasn't sure which cases are broken there. Removed it for now, will revisit if this is an issue for merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services