You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/09/06 09:25:07 UTC

[GitHub] [spark] panbingkun opened a new pull request, #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

panbingkun opened a new pull request, #42834:
URL: https://github.com/apache/spark/pull/42834

   ### What changes were proposed in this pull request?
   This pr aims to refine docstring of `DataFrame.groupBy/rollup/cube`.
   
   ### Why are the changes needed?
   To improve PySpark documentation.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Pass GA.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42834:
URL: https://github.com/apache/spark/pull/42834#issuecomment-1708026390

   thanks @panbingkun , would you mind waiting for https://github.com/apache/spark/pull/42832 which happen to add new feature to `rollup/cube` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42834:
URL: https://github.com/apache/spark/pull/42834#issuecomment-1708082292

   > thanks @panbingkun , would you mind waiting for #42832 which happen to add new feature to `rollup/cube` ?
   
   Okay, let's wait for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42834:
URL: https://github.com/apache/spark/pull/42834#issuecomment-1711015126

   @zhengruifeng 
   I have synchronized the changes after https://github.com/apache/spark/pull/42832 to this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42834:
URL: https://github.com/apache/spark/pull/42834#issuecomment-1707987821

   cc @HyukjinKwon @zhengruifeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42834:
URL: https://github.com/apache/spark/pull/42834#issuecomment-1712992340

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42834:
URL: https://github.com/apache/spark/pull/42834#issuecomment-1712992453

   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42834: [SPARK-45044][PYTHON][DOCS] Refine docstring of `groupBy/rollup/cube`
URL: https://github.com/apache/spark/pull/42834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org