You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/23 07:42:05 UTC
[GitHub] [solr] anshumg opened a new pull request #692: Update branch_9_0 changelog
anshumg opened a new pull request #692:
URL: https://github.com/apache/solr/pull/692
This contains changes from https://github.com/apache/solr/pull/643 and https://github.com/apache/solr/pull/647
I'll be moving things around a bit more and consolidating this. I have some draft changes but should be ready to go tomorrow.
The intention here is to merge these updates into branch_9_0 and then take those changes to main and branch_9x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] anshumg commented on a change in pull request #692: Update branch_9_0 changelog
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #692:
URL: https://github.com/apache/solr/pull/692#discussion_r832520160
##########
File path: solr/CHANGES.txt
##########
@@ -244,12 +223,14 @@ when told to. The admin UI now tells it to. (Nazerke Seidan, David Smiley)
* SOLR-11905: New Admin UI Query screen input boxes for JSON query and facet DSL (janhoy)
-* SOLR-15556: Migrate the Ref Guide to be built with Antora, enabling many new features (Cassandra Targett, Houston Putman, Mike Drob)
+* SOLR-15556: Migrate the Ref Guide to be built with Antora, enabling many new features
+ (Cassandra Targett, Houston Putman, Mike Drob)
* SOLR-15965: Use better signatures for the PKI Authentication plugin. (Mike Drob)
* SOLR-15982: Add end time value to backup response, standardize backup response key names and date formats (Artem Abeleshev, Christine Poerschke, Houston Putman)
+<<<<<<< HEAD
Review comment:
ah, ⌘ F didn't do the job when I pushed this PR. Thanks for catching these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #692: Update branch_9_0 changelog
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #692:
URL: https://github.com/apache/solr/pull/692#issuecomment-1070899480
Are you ready to bring this up to date and merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #692: Update branch_9_0 changelog
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #692:
URL: https://github.com/apache/solr/pull/692#issuecomment-1070899480
Are you ready to bring this up to date and merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] anshumg merged pull request #692: Update branch_9_0 changelog
Posted by GitBox <gi...@apache.org>.
anshumg merged pull request #692:
URL: https://github.com/apache/solr/pull/692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] anshumg commented on pull request #692: Update branch_9_0 changelog
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #692:
URL: https://github.com/apache/solr/pull/692#issuecomment-1074527817
I've updated the PR. There were more conflicts than I was expecting, so will merge this in once someone confirms I didn't do something crazy here.
Thanks for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #692: Update branch_9_0 changelog
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #692:
URL: https://github.com/apache/solr/pull/692#issuecomment-1074868902
I diffed the jira numbers and looked into the changes. All looks good to me, except the remnants of merge markers `<<<< HEAD` etc mentioned above.
After merge, please replace the entire 9.0 section on branch_9x and main with the exact same content.
One thing I have NOT done is to look at branch_9x and main for other JIRA entries that have been put in the 9.0 section but not yet merged to branch_9_0, that will need to be moved to the correct section prior to overwriting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #692: Update branch_9_0 changelog
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #692:
URL: https://github.com/apache/solr/pull/692#discussion_r831863255
##########
File path: solr/CHANGES.txt
##########
@@ -244,12 +223,14 @@ when told to. The admin UI now tells it to. (Nazerke Seidan, David Smiley)
* SOLR-11905: New Admin UI Query screen input boxes for JSON query and facet DSL (janhoy)
-* SOLR-15556: Migrate the Ref Guide to be built with Antora, enabling many new features (Cassandra Targett, Houston Putman, Mike Drob)
+* SOLR-15556: Migrate the Ref Guide to be built with Antora, enabling many new features
+ (Cassandra Targett, Houston Putman, Mike Drob)
* SOLR-15965: Use better signatures for the PKI Authentication plugin. (Mike Drob)
* SOLR-15982: Add end time value to backup response, standardize backup response key names and date formats (Artem Abeleshev, Christine Poerschke, Houston Putman)
+<<<<<<< HEAD
Review comment:
Remove these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org