[GitHub] [flink] bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

[GitBox <gi...@apache.org>]

bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema
URL: https://github.com/apache/flink/pull/8214#discussion_r277772350
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/catalog/FlinkCatalogManager.java
 ##########
 @@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog;
+
+import org.apache.flink.table.api.CatalogAlreadyExistException;
+import org.apache.flink.table.api.CatalogNotExistException;
+import org.apache.flink.table.catalog.exceptions.DatabaseNotExistException;
+import org.apache.flink.util.StringUtils;
+
+import org.apache.calcite.jdbc.CalciteSchema;
+import org.apache.calcite.schema.SchemaPlus;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Set;
+
+import static org.apache.flink.util.Preconditions.checkArgument;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ *	A CatalogManager implementation for Flink.
+ *  TODO: [FLINK-11275] Decouple CatalogManager with Calcite
+ *  	Idealy FlinkCatalogManager should be in flink-table-api-java module.
+ *  	But due to that it currently depends on Calcite, a dependency that flink-table-api-java doesn't have right now.
+ *  	We temporarily put FlinkCatalogManager in flink-table-planner-blink.
+ */
+public class FlinkCatalogManager implements CatalogManager {
+	private static final Logger LOG = LoggerFactory.getLogger(FlinkCatalogManager.class);
+
+	public static final String BUILTIN_CATALOG_NAME = "builtin";
+
+	// The catalog to hold all registered and translated tables
+	// We disable caching here to prevent side effects
+	private CalciteSchema internalSchema = CalciteSchema.createRootSchema(false, false);
+	private SchemaPlus rootSchema = internalSchema.plus();
+
+	// A map between names and catalogs.
+	private Map<String, ReadableCatalog> catalogs;
+
+	// The name of the default catalog and schema
+	private String currentCatalogName;
+	private String currentDbName;
+
+	public FlinkCatalogManager() {
+		LOG.info("Initializing FlinkCatalogManager");
+		catalogs = new HashMap<>();
+
+		GenericInMemoryCatalog inMemoryCatalog = new GenericInMemoryCatalog(BUILTIN_CATALOG_NAME);
+		catalogs.put(BUILTIN_CATALOG_NAME, inMemoryCatalog);
+		currentCatalogName = BUILTIN_CATALOG_NAME;
+		currentDbName = inMemoryCatalog.getCurrentDatabase();
+
+		CatalogCalciteSchema.registerCatalog(rootSchema, BUILTIN_CATALOG_NAME, inMemoryCatalog);
+	}
+
+	@Override
+	public void registerCatalog(String catalogName, ReadableCatalog catalog) throws CatalogAlreadyExistException {
+		checkArgument(!StringUtils.isNullOrWhitespaceOnly(catalogName), "catalogName cannot be null or empty");
+		checkNotNull(catalog, "catalog cannot be null");
+
+		if (catalogs.containsKey(catalogName)) {
+			throw new CatalogAlreadyExistException(catalogName);
+		}
+
+		catalogs.put(catalogName, catalog);
+		catalog.open();
+		CatalogCalciteSchema.registerCatalog(rootSchema, catalogName, catalog);
+	}
+
+	@Override
+	public ReadableCatalog getCatalog(String catalogName) throws CatalogNotExistException {
+		if (!catalogs.keySet().contains(catalogName)) {
+			throw new CatalogNotExistException(catalogName);
+		}
+
+		return catalogs.get(catalogName);
+	}
+
+	@Override
+	public Set<String> getCatalogNames() {
+		return catalogs.keySet();
+	}
+
+	@Override
+	public ReadableCatalog getCurrentCatalog() {
+		return catalogs.get(currentCatalogName);
+	}
+
+	@Override
+	public String getCurrentDatabaseName() {
+		return currentDbName;
+	}
+
+	@Override
+	public void setCurrentCatalog(String catalogName) throws CatalogNotExistException {
+		checkArgument(!StringUtils.isNullOrWhitespaceOnly(catalogName), "catalogName cannot be null or empty");
+
+		if (!catalogs.keySet().contains(catalogName)) {
+			throw new CatalogNotExistException(catalogName);
+		}
+
+		if (!currentCatalogName.equals(catalogName)) {
+			currentCatalogName = catalogName;
+			currentDbName = catalogs.get(catalogName).getCurrentDatabase();
+			LOG.info("Set default catalog as '{}' and default database as '{}'", currentCatalogName, currentDbName);
+		}
+	}
+
+	@Override
+	public void setCurrentCatalogAndDatabase(String catalogName, String databaseName) throws CatalogNotExistException, DatabaseNotExistException {
+		checkArgument(!StringUtils.isNullOrWhitespaceOnly(catalogName), "catalogName cannot be null or empty");
+		checkArgument(!StringUtils.isNullOrWhitespaceOnly(databaseName), "databaseNName cannot be null or empty");
+
+		if (!catalogs.containsKey(catalogName)) {
+			throw new CatalogNotExistException(catalogName);
+		}
+
+		if (!catalogs.get(catalogName).listDatabases().contains(databaseName)) {
+			throw new DatabaseNotExistException(catalogName, databaseName);
+		}
+
+		if (!currentCatalogName.equals(catalogName) || !currentDbName.equals(databaseName)) {
+			currentCatalogName = catalogName;
 
 Review comment:
   good catch. We kind of unified the "current database" concept in CatalogManager and the "default database" concept in a catalog in Flink, which are separated in Blink. I'll update accordingly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services