You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "George P. Stathis (JIRA)" <ji...@apache.org> on 2010/09/02 03:50:53 UTC
[jira] Created: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
NPE's thrown when attempting to load hbase columns containing null values
-------------------------------------------------------------------------
Key: PIG-1596
URL: https://issues.apache.org/jira/browse/PIG-1596
Project: Pig
Issue Type: Bug
Components: data
Affects Versions: 0.7.0
Reporter: George P. Stathis
Fix For: 0.8.0, 0.9.0
Attachments: null_hbase_records.patch
I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig-*-SNAPSHOT.jar and not the build/pig-*-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Jeff Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905388#action_12905388 ]
Jeff Zhang commented on PIG-1596:
---------------------------------
George, thanks for your suggestion. And I believe you are using latest HBaseStorage in trunk. What you pointed at is really a problem, and I have another solution for this. If the cell is null, we put an empty byte array in DataByteArray, I think it should been the LoadFunc's reponponslibity to handle null cell.
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Jeff Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906418#action_12906418 ]
Jeff Zhang commented on PIG-1596:
---------------------------------
Combine the new test case with existing ones. And commit the patch to both trunk and branch-0.8
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch, PIG_1596_2.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "George P. Stathis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905393#action_12905393 ]
George P. Stathis commented on PIG-1596:
----------------------------------------
Works just as well with less files modified. Thanks Jeff. How about the bin/pig modification? Is it ok or am I missing a step in my build process? Without it, when I download trunk and build, I get NoClassDefFoundError errors out of the box when I attempt to rum in grunt mode.
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "George P. Stathis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George P. Stathis updated PIG-1596:
-----------------------------------
Attachment: null_hbase_records.patch
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig-*-SNAPSHOT.jar and not the build/pig-*-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905818#action_12905818 ]
Dmitriy V. Ryaboy commented on PIG-1596:
----------------------------------------
I will review on Friday.
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch, PIG_1596_2.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Jeff Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Zhang updated PIG-1596:
----------------------------
Attachment: PIG_1596_2.patch
Dmitriy, you are right. I updated the patch according your suggestion.
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch, PIG_1596_2.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906305#action_12906305 ]
Dmitriy V. Ryaboy commented on PIG-1596:
----------------------------------------
+1
before committing, do you mind combining the new test with one of the existing ones? Trying to keep the test suite at under 24 hours :)
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch, PIG_1596_2.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Jeff Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Zhang resolved PIG-1596.
-----------------------------
Fix Version/s: (was: 0.9.0)
Resolution: Fixed
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch, PIG_1596_2.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Jeff Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Zhang updated PIG-1596:
----------------------------
Attachment: PIG_1596.patch
Attach patch (modify HBaseStorage and add new TestCase)
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905404#action_12905404 ]
Dmitriy V. Ryaboy commented on PIG-1596:
----------------------------------------
Jeff,
I think it's clearer if you insert null into the tuple, not an empty DataByteArray (and assertNull in the test)
George, the SNAPSHOT thing is a real bug, thanks for catching that, this happened when pig was made available through maven in PIG-1334.
I'll create a separate ticket for that.
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1596) NPE's thrown when attempting to load
hbase columns containing null values
Posted by "George P. Stathis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George P. Stathis updated PIG-1596:
-----------------------------------
Description:
I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
was:
I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig-*-SNAPSHOT.jar and not the build/pig-*-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
> NPE's thrown when attempting to load hbase columns containing null values
> -------------------------------------------------------------------------
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
> Issue Type: Bug
> Components: data
> Affects Versions: 0.7.0
> Reporter: George P. Stathis
> Fix For: 0.8.0, 0.9.0
>
> Attachments: null_hbase_records.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle loading hbase rows containing null cell values (since hbase is all about sparsly populated data rows). As it stands, a DataByteArray can be created with a null mData if a cell has no value, which causes NPEs by simply attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a separate patch for this, I'll be happy to submit it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.