You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2023/12/15 23:28:57 UTC

Re: [PR] [MINOR][SQL][PYTHON] Rename Python plan node names [spark]

ueshin commented on code in PR #44373:
URL: https://github.com/apache/spark/pull/44373#discussion_r1428582926


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -839,7 +839,7 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
       case logical.MapInPandas(func, output, child, isBarrier) =>
         execution.python.MapInPandasExec(func, output, planLater(child), isBarrier) :: Nil
       case logical.PythonMapInArrow(func, output, child, isBarrier) =>

Review Comment:
   Do we also want to rename logical plans? I see at least `logical.PythonMapInArrow` here, which is inconsistent with the physical plan.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org