You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Niklas Gustavsson <ni...@protocol7.com> on 2010/01/21 09:53:20 UTC
Re: FTP Server - MD5 and MMD5 command replies when a file name or
path contains spaces
On Wed, Jan 20, 2010 at 4:16 PM, Sai Pullabhotla
<sa...@jmethods.com> wrote:
> I wonder if the file name in the 251 reply should be enclosed in
> double quotes. This is based on the examples in the RFC. The RFC does
> not explicitly say anything about double quotes.
I agree. Could you open a JIRA for this? And feel free to fix it for
1.0.x and 1.1.x if you got the time :-)
/niklas
Re: FTP Server - MD5 and MMD5 command replies when a file name or
path contains spaces
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Thu, Jan 28, 2010 at 5:17 PM, Sai Pullabhotla
<sa...@jmethods.com> wrote:
> Well, I guess I kind of screwed it up by not updating the test case. I
> did see some emails from Hudson that the builds have failed. I checked
> in the fix for the test cases. Hope it is all good now.
That's what we got Hudson for :-) I've reran two of the Hudson builds
as they failed for other reasons, now all seems good.
/niklas
Re: FTP Server - MD5 and MMD5 command replies when a file name or
path contains spaces
Posted by Sai Pullabhotla <sa...@jmethods.com>.
Well, I guess I kind of screwed it up by not updating the test case. I
did see some emails from Hudson that the builds have failed. I checked
in the fix for the test cases. Hope it is all good now.
Regards,
Sai Pullabhotla
On Thu, Jan 21, 2010 at 8:45 AM, Niklas Gustavsson <ni...@protocol7.com> wrote:
> On Thu, Jan 21, 2010 at 3:36 PM, Sai Pullabhotla
> <sa...@jmethods.com> wrote:
>> I'm sure you can fix it in case if I screw
>> something up :).
>
> I don't think you will, but sure :-)
>
> /niklas
>
Re: FTP Server - MD5 and MMD5 command replies when a file name or
path contains spaces
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Thu, Jan 21, 2010 at 3:36 PM, Sai Pullabhotla
<sa...@jmethods.com> wrote:
> I'm sure you can fix it in case if I screw
> something up :).
I don't think you will, but sure :-)
/niklas
Re: FTP Server - MD5 and MMD5 command replies when a file name or
path contains spaces
Posted by Sai Pullabhotla <sa...@jmethods.com>.
I will give it a shot. I always used the Merge option in Eclipse. But,
I'm a little hesitant to do it on someone else's repository. I will
give it a shot anyway. I'm sure you can fix it in case if I screw
something up :).
Regards,
Sai Pullabhotla
On Thu, Jan 21, 2010 at 8:15 AM, Niklas Gustavsson <ni...@protocol7.com> wrote:
> On Thu, Jan 21, 2010 at 3:02 PM, Sai Pullabhotla
> <sa...@jmethods.com> wrote:
>> Sure, not a problem. Is it okay if I check it into trunk? Would you be
>> able to merge it into appropriate branches? Or would you rather prefer
>> patch attached to the JIRA issue?
>
> Give it a try to get it into both branches. Here's how I do it:
> * Develop the solution in trunk
> * Extract a patch (Team -> Create patch if you use Eclipse)
> * Review this so I only get what I really want
> * Apply patch in 1.0.x branch
> * Test and verify
> * Commit to both branches
>
> /niklas
>
Re: FTP Server - MD5 and MMD5 command replies when a file name or
path contains spaces
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Thu, Jan 21, 2010 at 3:02 PM, Sai Pullabhotla
<sa...@jmethods.com> wrote:
> Sure, not a problem. Is it okay if I check it into trunk? Would you be
> able to merge it into appropriate branches? Or would you rather prefer
> patch attached to the JIRA issue?
Give it a try to get it into both branches. Here's how I do it:
* Develop the solution in trunk
* Extract a patch (Team -> Create patch if you use Eclipse)
* Review this so I only get what I really want
* Apply patch in 1.0.x branch
* Test and verify
* Commit to both branches
/niklas
Re: FTP Server - MD5 and MMD5 command replies when a file name or
path contains spaces
Posted by Sai Pullabhotla <sa...@jmethods.com>.
Sure, not a problem. Is it okay if I check it into trunk? Would you be
able to merge it into appropriate branches? Or would you rather prefer
patch attached to the JIRA issue?
Regards,
Sai Pullabhotla
On Thu, Jan 21, 2010 at 2:53 AM, Niklas Gustavsson <ni...@protocol7.com> wrote:
> On Wed, Jan 20, 2010 at 4:16 PM, Sai Pullabhotla
> <sa...@jmethods.com> wrote:
>> I wonder if the file name in the 251 reply should be enclosed in
>> double quotes. This is based on the examples in the RFC. The RFC does
>> not explicitly say anything about double quotes.
>
> I agree. Could you open a JIRA for this? And feel free to fix it for
> 1.0.x and 1.1.x if you got the time :-)
>
> /niklas
>