[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

[GitBox <gi...@apache.org>]

mxm commented on code in PR #493:
URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057362585


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java:
##########
@@ -122,7 +130,15 @@ public CollectedMetrics getMetricsHistory(
 
         // Add scaling metrics to history if they were computed successfully
         scalingMetricHistory.put(clock.instant(), scalingMetrics);
-        scalingInformation.updateMetricHistory(currentJobStartTs, scalingMetricHistory);
+        scalingInformation.updateMetricHistory(currentJobUpdateTs, scalingMetricHistory);
+
+        if (currentJobUpdateTs
+                .plus(stabilizationDuration)
+                .isAfter(clock.instant().minus(metricsWindowDuration))) {

Review Comment:
   That's a great idea. I've added another commit which does that. I might still create an extra JIRA for it to document the new feature set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org