[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15594: [improve][client] Throw more meaningful derived exception instead of PulsarClientException

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #15594:
URL: https://github.com/apache/pulsar/pull/15594#discussion_r1051583153


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4301,10 +4301,11 @@ public static CompletableFuture<PartitionedTopicMetadata> getPartitionedTopicMet
                                 }).exceptionally(ex -> {
                                     Throwable throwable2 = FutureUtil.unwrapCompletionException(ex);
                                     if (throwable2 instanceof RestException) {
-                                        log.warn("Failed to authorize {} on topic {}", clientAppId, topicName);
-                                        authorizationFuture.completeExceptionally(new PulsarClientException(
-                                                String.format("Authorization failed %s on topic %s with error %s",
-                                                clientAppId, topicName, throwable2.getMessage())));

Review Comment:
   @eolivelli Could you explain in details? I'm also wondering what did you mean by `split the path per component`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org