[GitHub] [kafka] jolshan commented on a diff in pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

[GitBox <gi...@apache.org>]

jolshan commented on code in PR #13129:
URL: https://github.com/apache/kafka/pull/13129#discussion_r1081661935


##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig {
     /** <code> transaction.timeout.ms </code> */
     public static final String TRANSACTION_TIMEOUT_CONFIG = "transaction.timeout.ms";
     public static final String TRANSACTION_TIMEOUT_DOC = "The maximum amount of time in ms that the transaction coordinator will wait for a transaction status update from the producer before proactively aborting the ongoing transaction." +
+            "The transaction status update happens on the first producer send, on adding new partitions to the transaction, and on commit. " +

Review Comment:
   Ah -- I think I also had this confusion since there are notions of expiration and timeout. But yes, looking at your links I see that timeout is affected by the start timestamp only, while expiration is affected by the other components mentioned in the current description (adding partitions etc).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org