[GitHub] [beam] damondouglas commented on a change in pull request #11564: [Beam-9679] Add Core Transforms section / Map lesson to the Go SDK katas

[GitBox <gi...@apache.org>]

damondouglas commented on a change in pull request #11564:
URL: https://github.com/apache/beam/pull/11564#discussion_r418386969



##########
File path: learning/katas/go/Core Transforms/Map/ParDo/pkg/task/task.go
##########
@@ -0,0 +1,25 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package task
+
+import "github.com/apache/beam/sdks/go/pkg/beam"
+
+func ApplyTransform(s beam.Scope, input beam.PCollection) beam.PCollection {
+	processFn := func(element int) int {

Review comment:
       May we consider keeping it?  I found [these guidelines](https://github.com/golang/go/wiki/CodeReviewComments#variable-names) on variable naming.  I wasn't sure if they apply but my intuition is that `multiplyBy10Fn` might be too long?  I think even my `processFn` is too long.  I actually prefer to keep in line [with the example from the godocs](https://godoc.org/github.com/apache/beam/sdks/go/pkg/beam#ParDo) but working with the IntelliJ answer placeholder made the presentation of a separate function unclear.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org