[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #228: README.md: Add triple DES CBC to the list of supported ciphers

[GitBox <gi...@apache.org>]

tomaswolf commented on code in PR #228:
URL: https://github.com/apache/mina-sshd/pull/228#discussion_r906783182


##########
README.md:
##########
@@ -59,7 +59,7 @@ based applications requiring SSH support.
 
 * **Authentication methods**: hostbased, publickey, [OpenSSH host-based public-key](https://github.com/openssh/openssh-portable/blob/1781f507c11/PROTOCOL#L349), keyboard-interactive, password
 * **Ciphers**: aes128cbc, aes128ctr, aes192cbc, aes192ctr, aes256cbc, aes256ctr, arcfour128, arcfour256, blowfishcbc, tripledescbc,
-aes128-gcm@openssh.com, aes256-gcm@openssh.com, chacha20-poly1305@openssh.com
+aes128-gcm@openssh.com, aes256-gcm@openssh.com, chacha20-poly1305@openssh.com, 3des-cbc

Review Comment:
   I see "tripledescbc" in the line above. That's 3des-cbc. And "blowfishcbc" should be "blowfish-cbc".
   
   When that was written, the Java enum constant names were used by mistake instead of the algorithm names.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org