You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "JooHyukKim (via GitHub)" <gi...@apache.org> on 2023/07/01 06:33:31 UTC
[GitHub] [pulsar] JooHyukKim opened a new pull request, #20701: [fix][cli] Fix error messages in `CmdNameSpaces` and `CmdTopics`
JooHyukKim opened a new pull request, #20701:
URL: https://github.com/apache/pulsar/pull/20701
### Motivation
Fixes error messages `CmdNameSpaces` and `CmdTopics` that describe opposite of what really happens.
### Modifications
Same as title.
### Verifying this change
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20701: [fix][cli] Fix error messages in `CmdNameSpaces` and `CmdTopics`
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20701:
URL: https://github.com/apache/pulsar/pull/20701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20701: [fix][cli] Fix error messages in `CmdNameSpaces` and `CmdTopics`
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20701:
URL: https://github.com/apache/pulsar/pull/20701#issuecomment-1619509977
Merging...
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20701: [fix][cli] Fix error messages in `CmdNameSpaces` and `CmdTopics`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20701:
URL: https://github.com/apache/pulsar/pull/20701#issuecomment-1618087523
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20701?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20701](https://app.codecov.io/gh/apache/pulsar/pull/20701?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fcaa60e) into [master](https://app.codecov.io/gh/apache/pulsar/commit/c5237eaeeee1d1444deda94a69721a12b19c5ba1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c5237ea) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20701 +/- ##
============================================
- Coverage 73.13% 73.10% -0.04%
+ Complexity 32101 32089 -12
============================================
Files 1871 1871
Lines 138982 138982
Branches 15283 15283
============================================
- Hits 101651 101599 -52
- Misses 29280 29319 +39
- Partials 8051 8064 +13
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.11% <0.00%> (-0.10%)` | :arrow_down: |
| systests | `24.98% <0.00%> (-0.15%)` | :arrow_down: |
| unittests | `72.37% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java](https://app.codecov.io/gh/apache/pulsar/pull/20701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWROYW1lc3BhY2VzLmphdmE=) | `76.17% <0.00%> (ø)` | |
| [...in/java/org/apache/pulsar/admin/cli/CmdTopics.java](https://app.codecov.io/gh/apache/pulsar/pull/20701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWRUb3BpY3MuamF2YQ==) | `78.94% <0.00%> (ø)` | |
... and [77 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20701/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org