[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

[GitBox <gi...@apache.org>]

acassis commented on a change in pull request #5529:
URL: https://github.com/apache/incubator-nuttx/pull/5529#discussion_r809133113



##########
File path: arch/risc-v/src/qemu-rv/qemu_rv_start.c
##########
@@ -60,10 +60,15 @@ uintptr_t g_idle_topstack = QEMU_RV_IDLESTACK_TOP;
  * Name: qemu_rv_start
  ****************************************************************************/
 
-void qemu_rv_start(void)
+void qemu_rv_start(int mhartid)
 {
   uint32_t *dest;
 
+  if (0 < mhartid)

Review comment:
       ```suggestion
    if (mhartid > 0)
   ```
   I think for equal comparison if (0 == ...) it is ok, but for greater/lower comparison it doesn't help and make more difficult to read




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org