You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/06/01 16:55:14 UTC
[GitHub] [activemq-artemis] Yesenkov opened a new pull request, #4100: Update ActiveMQServerImpl.java
Yesenkov opened a new pull request, #4100:
URL: https://github.com/apache/activemq-artemis/pull/4100
This fixes the situation in ActiveMQServerImpl.createSession () ActiveMQServerImpl.checkSessionLimit () is called with the ServerSessionImpl.validatedUser parameter, but to count the list of sessions, the ActiveMQServerImpl.getSessionCountForUser () method is called, which already iterates over the sessions, ServerSessionImpl.getUsername () is called. In the case of certificate authentication via the TextFileCertificateLoginModule, getUsername() is always null for client connections, while ServerSessionImpl.validatedUser is set to the normal user ID via the call to securityStore.authenticate() at the very beginning of the ActiveMQServerImpl.createSession() method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4100: Update ActiveMQServerImpl.java
Posted by GitBox <gi...@apache.org>.
jbertram commented on PR #4100:
URL: https://github.com/apache/activemq-artemis/pull/4100#issuecomment-1145317264
Basic tests for resource limits are at `org.apache.activemq.artemis.tests.integration.server.ResourceLimitTest`. A test using certificates is at `org.apache.activemq.artemis.tests.integration.security.SecurityTest#testJAASSecurityManagerAuthenticationWithCerts()`. Take bits and pieces from both and create a new class `org.apache.activemq.artemis.tests.integration.server.ResourceLimitTestWithCerts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4100: Update ActiveMQServerImpl.java
Posted by GitBox <gi...@apache.org>.
jbertram commented on PR #4100:
URL: https://github.com/apache/activemq-artemis/pull/4100#issuecomment-1145314156
This really needs a test to validate the fix and also to ensure there are no regressions in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Yesenkov closed pull request #4100: Update ActiveMQServerImpl.java
Posted by GitBox <gi...@apache.org>.
Yesenkov closed pull request #4100: Update ActiveMQServerImpl.java
URL: https://github.com/apache/activemq-artemis/pull/4100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org