You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/08/20 00:15:01 UTC

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell 

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17796


Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................

IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Previous patch added support for retaining cookies in impala-shell.
Some issues were found when porting the patch to impyla, like expiry
time of cookie could be none, coding not as Pythonic coding.
This patch fixs those issues for impala-shell.

Testing:
 - Passed core test.

Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
---
M shell/ImpalaHttpClient.py
M shell/cookie_util.py
M tests/shell/test_cookie_util.py
3 files changed, 33 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17796/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 19:17:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 01:42:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17796/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17796/3//COMMIT_MSG@11
PS3, Line 11: Pythonic coding
Adding Attila to verify changes are in line with python best practices



-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 22:04:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9329/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 00:37:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9330/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 01:49:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................

IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Previous patch added support for retaining cookies in impala-shell.
Some issues were found when porting the patch to impyla, like expiry
time of cookie could be none, coding not as Pythonic coding.
This patch fixs those issues for impala-shell.

Testing:
 - Passed core test.

Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Reviewed-on: http://gerrit.cloudera.org:8080/17796
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/ImpalaHttpClient.py
M shell/cookie_util.py
M tests/shell/test_cookie_util.py
3 files changed, 33 insertions(+), 24 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 19:30:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7412/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Aug 2021 19:30:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................

IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Previous patch added support for retaining cookies in impala-shell.
Some issues were found when porting the patch to impyla, like expiry
time of cookie could be none, coding not as Pythonic coding.
This patch fixs those issues for impala-shell.

Testing:
 - Passed core test.

Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
---
M shell/ImpalaHttpClient.py
M shell/cookie_util.py
M tests/shell/test_cookie_util.py
3 files changed, 33 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/17796/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17796/2/shell/ImpalaHttpClient.py
File shell/ImpalaHttpClient.py:

http://gerrit.cloudera.org:8080/#/c/17796/2/shell/ImpalaHttpClient.py@119
PS2, Line 119:  
flake8: E201 whitespace after '{'


http://gerrit.cloudera.org:8080/#/c/17796/2/shell/ImpalaHttpClient.py@119
PS2, Line 119:  
flake8: E202 whitespace before '}'



-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 00:16:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10784 (part 2): Fix retaining cookies for impala-shell

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17796 )

Change subject: IMPALA-10784 (part 2): Fix retaining cookies for impala-shell
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17796/2/shell/ImpalaHttpClient.py
File shell/ImpalaHttpClient.py:

http://gerrit.cloudera.org:8080/#/c/17796/2/shell/ImpalaHttpClient.py@119
PS2, Line 119:  
> flake8: E202 whitespace before '}'
fixed


http://gerrit.cloudera.org:8080/#/c/17796/2/shell/ImpalaHttpClient.py@119
PS2, Line 119:  
> flake8: E201 whitespace after '{'
fixed



-- 
To view, visit http://gerrit.cloudera.org:8080/17796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65432b952929c1c96a081bb87fd4a096624d711b
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 01:23:20 +0000
Gerrit-HasComments: Yes