[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #4758: HADOOP-18408. ABFS: Ignoring testResilienceAsExpected for nonHNS configuration

[GitBox <gi...@apache.org>]

pranavsaxena-microsoft commented on code in PR #4758:
URL: https://github.com/apache/hadoop/pull/4758#discussion_r949261952


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/commit/ITestAbfsRenameStageFailure.java:
##########
@@ -45,7 +45,7 @@ public ITestAbfsRenameStageFailure() throws Exception {
   public void setup() throws Exception {
     binding.setup();
     super.setup();
-  }
+    }

Review Comment:
   Extra space to be removed.



##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestRenameStageFailure.java:
##########
@@ -121,6 +121,7 @@ protected boolean requireRenameResilience() {
 
   @Test
   public void testResilienceAsExpected() throws Throwable {
+    Assume.assumeTrue(etagsPreserved);

Review Comment:
   What if its HNS account and etags are not preserved due to code-issue, this test will be ignored and code shall be merged in trunk. Is it possible to know if its non-HNS account and then ignore on basis of that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org