[GitHub] [spark] vanzin edited a comment on issue #23843: [SPARK-26938][CORE]fill taskMetrics to SparkListenerTaskEnd Event even though task is failed

[GitBox <gi...@apache.org>]

vanzin edited a comment on issue #23843: [SPARK-26938][CORE]fill taskMetrics to SparkListenerTaskEnd Event even though task is failed
URL: https://github.com/apache/spark/pull/23843#issuecomment-473976134
 
 
   I'm still not sure I understand how you get into this situation.
   
   Whatever the underlying problem is, this is the wrong fix. Data flows from scheduler to listener to the UI store, and here you're adding a feedback loop into that system. It's wrong. If the data made it into the UI store, but later cannot be seen in the UI, it means the listener somehow deleted that data when it shouldn't.
   
   My best guess of what you're saying is that if the task end event does not contain metrics, then the listener will delete the metrics, or mess them up, in the UI store. And that would be a bug in the listener.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org