[GitHub] [hive] marton-bod commented on a change in pull request #3104: HIVE-26036: NPE caused by getMTable() in ObjectStore

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #3104:
URL: https://github.com/apache/hive/pull/3104#discussion_r831165554



##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
##########
@@ -393,6 +393,14 @@ public void testPartitionOps() throws Exception {
     try (AutoCloseable c = deadline()) {
       objectStore.addPartition(part2);
     }
+    List<String> value3 = Arrays.asList("US", "MA");

Review comment:
       Can you add test cases for the other changed API methods too? Maybe create a new method for them, e.g. `testPartitionOpsWhenTableDoesNotExist`? This test method already seems quite messy and cluttered so maybe it's worth separating it out




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org