You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/01 15:27:05 UTC

[GitHub] [spark] attilapiros commented on a change in pull request #24245: [SPARK-13704][CORE][YARN] Reduce rack resolution time

attilapiros commented on a change in pull request #24245: [SPARK-13704][CORE][YARN] Reduce rack resolution time
URL: https://github.com/apache/spark/pull/24245#discussion_r270803352
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
 ##########
 @@ -833,7 +840,20 @@ private[spark] class TaskSchedulerImpl(
   }
 
   // By default, rack is unknown
-  def getRackForHost(value: String): Option[String] = None
+  def getRackForHost(hosts: String): Option[String] = {
 
 Review comment:
   Nit: rename hosts to host

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org