You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/06/10 19:06:07 UTC
[GitHub] [systemds] atefeh-asayesh opened a new pull request #1312: residency hospital matching algorithm
atefeh-asayesh opened a new pull request #1312:
URL: https://github.com/apache/systemds/pull/1312
Signed-off-by: Atefeh Asayesh <at...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1312: residency hospital matching algorithm
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on pull request #1312:
URL: https://github.com/apache/systemds/pull/1312#issuecomment-864466122
LGTM,
Thank you @atefeh-asayesh for your contribution. During the merge, I fixed minor formatting issues, removed unnecessary conditions, renamed the script to follow our builtin scripts' consistent naming format, and wrote a TODO to improve the script by vectorizing some operations and follow-up cleanups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi closed pull request #1312: residency hospital matching algorithm
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi closed pull request #1312:
URL: https://github.com/apache/systemds/pull/1312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on a change in pull request #1312: residency hospital matching algorithm
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on a change in pull request #1312:
URL: https://github.com/apache/systemds/pull/1312#discussion_r649937189
##########
File path: src/test/scripts/functions/builtin/residencymatch.dml
##########
@@ -0,0 +1,6 @@
+# this dml file will run the ResidencyMatchMain function in builtin functions in scripts/builtin
Review comment:
please add the license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] atefeh-asayesh commented on pull request #1312: residency hospital matching algorithm
Posted by GitBox <gi...@apache.org>.
atefeh-asayesh commented on pull request #1312:
URL: https://github.com/apache/systemds/pull/1312#issuecomment-859584771
Thanks, Dear Shafaq for your comments. I add the license and commit the new files in the current PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org