You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/16 09:16:33 UTC
[GitHub] [thrift] csordasmarton opened a new pull request #2491: THRIFT-5467 Python: fix CannotSendHeader exception
csordasmarton opened a new pull request #2491:
URL: https://github.com/apache/thrift/pull/2491
Based on the python source for `http.client`, `HTTPConnection.putheader`
can only be called after a request has been started, and before it's
been sent. Otherwise it will throw a `http.client.CannotSendHeader`
exception.
If the server returns a `Set-Cookie` header, the client will always
fail with the `CannotSendHeader` exception because `HTTPConnection.putheader`
is called after reading the response.
With this patch we will call this method before the request has been sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G merged pull request #2491: THRIFT-5467 Python: fix CannotSendHeader exception
Posted by GitBox <gi...@apache.org>.
Jens-G merged pull request #2491:
URL: https://github.com/apache/thrift/pull/2491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2491: THRIFT-5467 Python: fix CannotSendHeader exception
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2491:
URL: https://github.com/apache/thrift/pull/2491#issuecomment-1043616507
There's some strange message in the logs ... could you force-push to trigger CI again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] csordasmarton commented on pull request #2491: THRIFT-5467 Python: fix CannotSendHeader exception
Posted by GitBox <gi...@apache.org>.
csordasmarton commented on pull request #2491:
URL: https://github.com/apache/thrift/pull/2491#issuecomment-1046876853
@Jens-G Done. I also rebased my branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] csordasmarton commented on pull request #2491: THRIFT-5467 Python: fix CannotSendHeader exception
Posted by GitBox <gi...@apache.org>.
csordasmarton commented on pull request #2491:
URL: https://github.com/apache/thrift/pull/2491#issuecomment-1042670581
Is there anything I can do to get this merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org