You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "ksmou (via GitHub)" <gi...@apache.org> on 2023/06/15 03:04:18 UTC

[GitHub] [hudi] ksmou commented on a diff in pull request #8945: [HUDI-6360] spark-memory paramater should not be required in compactor or clustering job

ksmou commented on code in PR #8945:
URL: https://github.com/apache/hudi/pull/8945#discussion_r1230365325


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##########
@@ -87,7 +87,7 @@ public static class Config implements Serializable {
     public int parallelism = 1;
     @Parameter(names = {"--spark-master", "-ms"}, description = "Spark master")
     public String sparkMaster = null;
-    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory to use", required = true)
+    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory to use", required = false)
     public String sparkMemory = null;

Review Comment:
   I think remove the option `--spark-memory` is also a good choice. Setting executor memroy completely depends on `--executor-memory`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org