You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by bo...@apache.org on 2012/03/06 23:09:33 UTC

android commit: We show the default 404 on non-resolved domains

Updated Branches:
  refs/heads/master 8923e52a5 -> c5025ee2b


We show the default 404 on non-resolved domains


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/c5025ee2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/c5025ee2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/c5025ee2

Branch: refs/heads/master
Commit: c5025ee2bb2c5557b6caae3925129a305cd29da1
Parents: 8923e52
Author: Joe Bowser <bo...@apache.org>
Authored: Tue Mar 6 14:09:11 2012 -0800
Committer: Joe Bowser <bo...@apache.org>
Committed: Tue Mar 6 14:09:11 2012 -0800

----------------------------------------------------------------------
 framework/src/org/apache/cordova/DroidGap.java |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/c5025ee2/framework/src/org/apache/cordova/DroidGap.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/DroidGap.java b/framework/src/org/apache/cordova/DroidGap.java
index 283e655..ddc4fab 100755
--- a/framework/src/org/apache/cordova/DroidGap.java
+++ b/framework/src/org/apache/cordova/DroidGap.java
@@ -1185,13 +1185,16 @@ public class DroidGap extends Activity implements CordovaInterface {
                  }
              });
          }
-
          // If not, then display error dialog
          else {
+             final boolean exit = !(errorCode == WebViewClient.ERROR_HOST_LOOKUP);
              me.runOnUiThread(new Runnable() {
                  public void run() {
-                     me.appView.setVisibility(View.GONE);
-                     me.displayError("Application Error", description + " ("+failingUrl+")", "OK", true);
+                     if(exit)
+                     {
+                       me.appView.setVisibility(View.GONE);
+                       me.displayError("Application Error", description + " ("+failingUrl+")", "OK", exit);
+                     }
                  }
              });
          }