You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/10 02:30:32 UTC

[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4162: fix: fix jenkins upgrade

mintsweet commented on code in PR #4162:
URL: https://github.com/apache/incubator-devlake/pull/4162#discussion_r1065280110


##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -64,7 +64,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
             name: plugin.name,
             connectionId: cs.connectionId,
             entities: plugin.entities,
-            selectedEntites: cs.scopes?.[0].entities ?? [],
+            selectedEntites: cs.scopes.length > 0 ? cs.scopes[0].entities : [],

Review Comment:
   This is because you set the scope to [].
   
   when scope does not exist `cs.scope?.[0]?.entities ?? [] === []`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org