[jira] Commented: (SHINDIG-309) return HTTP errors from HttpFetcher subclasses

["Kevin Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599919#action_12599919 ] 

Kevin Brown commented on SHINDIG-309:
-------------------------------------

I really think both the OAuth and signed fetch need to be distinct interfaces to handle their specific needs. The current code is kind of convoluted.

The proposed interfaces that I've got in my workspace are:

public interface OAuthFetcher {
  public OAuthResponse fetch(OAuthRequest request) throws OAuthException
}

OAuthRequest extends HttpRequest and includes oauth state and the security token. OAuthResponse extends HttpResponse and includes appropriate response data there as well.

These are largely mirrored for Signed requests, with the parameters on SignedRequest being signing specific (sign viewer, sign owner).



> return HTTP errors from HttpFetcher subclasses
> ----------------------------------------------
>
>                 Key: SHINDIG-309
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-309
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Brian Eaton
>         Attachments: httperrors.patch
>
>
> The current implementation of BasicHttpFetcher fails if a server returns a 40x or 50x return code.  An exception gets thrown, which in turn is turned into a hard coded HTTP 500 response.
> This patch tweaks the code to allow the real response to be returned.
> This is prep work for supporting the OAuth problem reporting extension, to be shortly followed by the Scalable OAuth extension.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.