You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alexander Hitchins <al...@shapeblue.com> on 2014/03/06 15:59:35 UTC
Review Request 18844: Amended review request (origin:
https://reviews.apache.org/r/17531/)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18844/
-----------------------------------------------------------
Review request for cloudstack and Devdeep Singh.
Bugs: cloudstack-5440
https://issues.apache.org/jira/browse/cloudstack-5440
Repository: cloudstack-git
Description
-------
Please see amended script to add new os types. 32 & 64 bit separated and hard coded to specific Id numbers.
Diffs
-----
setup/db/db/schema-430to440.sql acc7e21
Diff: https://reviews.apache.org/r/18844/diff/
Testing
-------
Ran SQL, changes applied with no errors.
Thanks,
Alexander Hitchins
Re: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)
Posted by Daan Hoogland <da...@gmail.com>.
no problem, thanks
On Thu, Mar 6, 2014 at 11:06 PM, Alex Hitchins
<al...@shapeblue.com> wrote:
> Ah, sorry - I'll delete this one and add to the original.
>
>
> Regards
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>
> alex.hitchins@shapeblue.com
>
> -----Original Message-----
> From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
> Sent: 06 March 2014 17:39
> To: dev; Alex Hitchins
> Cc: Devdeep Singh
> Subject: Re: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)
>
> Alex, you don't have to create a new review request for this. If you upload a new version of the patch we can see the diff online and decide more easily that concerns were met and no new concerns where introduced.
>
> On Thu, Mar 6, 2014 at 3:59 PM, Alexander Hitchins <al...@shapeblue.com> wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/18844/
>> -----------------------------------------------------------
>>
>> Review request for cloudstack and Devdeep Singh.
>>
>>
>> Bugs: cloudstack-5440
>> https://issues.apache.org/jira/browse/cloudstack-5440
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Please see amended script to add new os types. 32 & 64 bit separated and hard coded to specific Id numbers.
>>
>>
>> Diffs
>> -----
>>
>> setup/db/db/schema-430to440.sql acc7e21
>>
>> Diff: https://reviews.apache.org/r/18844/diff/
>>
>>
>> Testing
>> -------
>>
>> Ran SQL, changes applied with no errors.
>>
>>
>> Thanks,
>>
>> Alexander Hitchins
>>
>
>
>
> --
> Daan
> Need Enterprise Grade Support for Apache CloudStack?
> Our CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> offers the best 24/7 SLA for CloudStack Environments.
>
> Apache CloudStack Bootcamp training courses
>
> **NEW!** CloudStack 4.2.1 training<http://shapeblue.com/cloudstack-training/>
> 18th-19th February 2014, Brazil. Classroom<http://shapeblue.com/cloudstack-training/>
> 17th-23rd March 2014, Region A. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
> 24th-28th March 2014, Region B. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
> 16th-20th June 2014, Region A. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
> 23rd-27th June 2014, Region B. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
--
Daan
RE: Review Request 18844: Amended review request (origin:
https://reviews.apache.org/r/17531/)
Posted by Alex Hitchins <al...@shapeblue.com>.
Ah, sorry - I'll delete this one and add to the original.
Regards
Alex Hitchins
D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
alex.hitchins@shapeblue.com
-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
Sent: 06 March 2014 17:39
To: dev; Alex Hitchins
Cc: Devdeep Singh
Subject: Re: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)
Alex, you don't have to create a new review request for this. If you upload a new version of the patch we can see the diff online and decide more easily that concerns were met and no new concerns where introduced.
On Thu, Mar 6, 2014 at 3:59 PM, Alexander Hitchins <al...@shapeblue.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18844/
> -----------------------------------------------------------
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Bugs: cloudstack-5440
> https://issues.apache.org/jira/browse/cloudstack-5440
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Please see amended script to add new os types. 32 & 64 bit separated and hard coded to specific Id numbers.
>
>
> Diffs
> -----
>
> setup/db/db/schema-430to440.sql acc7e21
>
> Diff: https://reviews.apache.org/r/18844/diff/
>
>
> Testing
> -------
>
> Ran SQL, changes applied with no errors.
>
>
> Thanks,
>
> Alexander Hitchins
>
--
Daan
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> offers the best 24/7 SLA for CloudStack Environments.
Apache CloudStack Bootcamp training courses
**NEW!** CloudStack 4.2.1 training<http://shapeblue.com/cloudstack-training/>
18th-19th February 2014, Brazil. Classroom<http://shapeblue.com/cloudstack-training/>
17th-23rd March 2014, Region A. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
24th-28th March 2014, Region B. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
16th-20th June 2014, Region A. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
23rd-27th June 2014, Region B. Instructor led, On-line<http://shapeblue.com/cloudstack-training/>
This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)
Posted by Daan Hoogland <da...@gmail.com>.
Alex, you don't have to create a new review request for this. If you
upload a new version of the patch we can see the diff online and
decide more easily that concerns were met and no new concerns where
introduced.
On Thu, Mar 6, 2014 at 3:59 PM, Alexander Hitchins
<al...@shapeblue.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18844/
> -----------------------------------------------------------
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Bugs: cloudstack-5440
> https://issues.apache.org/jira/browse/cloudstack-5440
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Please see amended script to add new os types. 32 & 64 bit separated and hard coded to specific Id numbers.
>
>
> Diffs
> -----
>
> setup/db/db/schema-430to440.sql acc7e21
>
> Diff: https://reviews.apache.org/r/18844/diff/
>
>
> Testing
> -------
>
> Ran SQL, changes applied with no errors.
>
>
> Thanks,
>
> Alexander Hitchins
>
--
Daan