[GitHub] [beam] vmarquez commented on issue #10546: [BEAM-9008] Add CassandraIO readAll method

[GitBox <gi...@apache.org>]

vmarquez commented on issue #10546: [BEAM-9008] Add CassandraIO readAll method
URL: https://github.com/apache/beam/pull/10546#issuecomment-607043571
 
 
   Hi @iemejia I've been busy with work and life but was finally able to this just about finished up!  To get around the connection issue (not caching the connection was causing the Cassandra tests to run for ~ten minutes!), by passing in a ReadAll<T> to the ReadFn, we're able to initiate a connection in the setup method, but we can still 'dynamically' use the passed in Read<T> to generate specific queries or query ranges.  
   
   As for a more advanced connection pooling, I'd prefer to get this merged in and then perhaps work on an additional PR.  
   
   There are some minor conflicts but I wasn't sure how you wanted to handle that, do you prefer I rebase against master (? that might then cause issues with Github's UI seeing other folks commits in my changelist), or should I merge master into this then another commit(which makes later squashing a bit harder).  Advice on that would be appreciated!  Thanks again for your guidance and help on this. I like the new design and the flexibility to modify the queries as well as ring ranges is pretty neat. 
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services