[GitHub] [incubator-doris] vagetablechicken edited a comment on issue #3273: fragment mem tracker doesn't be unregistered from parent

[GitBox <gi...@apache.org>]

vagetablechicken edited a comment on issue #3273: fragment mem tracker doesn't be unregistered from parent
URL: https://github.com/apache/incubator-doris/issues/3273#issuecomment-610819596
 
 
   So, I will just add `_mem_tracker->unregister_from_parent()` in `PlanFragmentExecutor::close()`, to unregister the fragment mem tracker from exec_env_mem_tracker.
   We should be careful about any access to child trackers. So we need add recursive depth for LogUsage(), ref impala
   https://github.com/apache/impala/blob/d877dbc572e95f086b37142e1d41231d5b6b7f9f/be/src/runtime/mem-tracker.cc#L300
   It will be safe to call `exec_env_mem_tracker.LogUsage(1)` anytime. But if we want to log the low-level mem tracker, we must ensure the children are still alive.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org