You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2015/01/26 15:59:59 UTC
[07/10] qpid-jms git commit: verify hashCode values as well after
deserializing
verify hashCode values as well after deserializing
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/b6126be7
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/b6126be7
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/b6126be7
Branch: refs/heads/master
Commit: b6126be74503fc2f742172f3dcad005f56c42dc1
Parents: 6b4869a
Author: Robert Gemmell <ro...@apache.org>
Authored: Mon Jan 26 13:03:41 2015 +0000
Committer: Robert Gemmell <ro...@apache.org>
Committed: Mon Jan 26 13:03:41 2015 +0000
----------------------------------------------------------------------
.../src/test/java/org/apache/qpid/jms/JmsQueueTest.java | 2 ++
.../src/test/java/org/apache/qpid/jms/JmsTemporaryQueueTest.java | 2 ++
.../src/test/java/org/apache/qpid/jms/JmsTemporaryTopicTest.java | 2 ++
.../src/test/java/org/apache/qpid/jms/JmsTopicTest.java | 2 ++
4 files changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/b6126be7/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsQueueTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsQueueTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsQueueTest.java
index 19f2994..1b94a4f 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsQueueTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsQueueTest.java
@@ -134,7 +134,9 @@ public class JmsQueueTest extends QpidJmsTestCase {
assertNotNull("Null destination returned", roundTripped);
assertEquals("Unexpected type", JmsQueue.class, roundTripped.getClass());
assertEquals("Unexpected name", name, ((JmsQueue)roundTripped).getQueueName());
+
assertEquals("Objects were not equal", queue, roundTripped);
+ assertEquals("Object hashCodes were not equal", queue.hashCode(), roundTripped.hashCode());
}
@Test
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/b6126be7/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryQueueTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryQueueTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryQueueTest.java
index 9b3495f..3b63741 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryQueueTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryQueueTest.java
@@ -142,7 +142,9 @@ public class JmsTemporaryQueueTest extends QpidJmsTestCase {
assertNotNull("Null destination returned", roundTripped);
assertEquals("Unexpected type", JmsTemporaryQueue.class, roundTripped.getClass());
assertEquals("Unexpected name", name, ((JmsTemporaryQueue)roundTripped).getQueueName());
+
assertEquals("Objects were not equal", queue, roundTripped);
+ assertEquals("Object hashCodes were not equal", queue.hashCode(), roundTripped.hashCode());
}
@Test
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/b6126be7/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryTopicTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryTopicTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryTopicTest.java
index 3618a5c..057465a 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryTopicTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTemporaryTopicTest.java
@@ -142,7 +142,9 @@ public class JmsTemporaryTopicTest extends QpidJmsTestCase {
assertNotNull("Null destination returned", roundTripped);
assertEquals("Unexpected type", JmsTemporaryTopic.class, roundTripped.getClass());
assertEquals("Unexpected name", name, ((JmsTemporaryTopic)roundTripped).getTopicName());
+
assertEquals("Objects were not equal", topic, roundTripped);
+ assertEquals("Object hashCodes were not equal", topic.hashCode(), roundTripped.hashCode());
}
@Test
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/b6126be7/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTopicTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTopicTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTopicTest.java
index c2e9998..ab1b8f2 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTopicTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsTopicTest.java
@@ -134,7 +134,9 @@ public class JmsTopicTest extends QpidJmsTestCase {
assertNotNull("Null destination returned", roundTripped);
assertEquals("Unexpected type", JmsTopic.class, roundTripped.getClass());
assertEquals("Unexpected name", name, ((JmsTopic)roundTripped).getTopicName());
+
assertEquals("Objects were not equal", topic, roundTripped);
+ assertEquals("Object hashCodes were not equal", topic.hashCode(), roundTripped.hashCode());
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org