You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/08/05 07:41:02 UTC
[GitHub] [couchdb] jiangphcn opened a new pull request #3057: fixup: Build couch_js for redhat linux
jiangphcn opened a new pull request #3057:
URL: https://github.com/apache/couchdb/pull/3057
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
When building couch_js in RHEL, there is one error occurring with "undefined reference to symbol '_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3'". This commit is to adjust binding library to address this issue.
```
Compiling priv/couch_ejson_compare/couch_ejson_compare.c
/usr/bin/ld: priv/couch_js/60/main.o: undefined reference to symbol '_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3'
//usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
ERROR: sh(cc priv/couch_js/60/http.o priv/couch_js/60/main.o priv/couch_js/60/utf8.o priv/couch_js/60/util.o -L/usr/local/lib -std=c++14 -lmozjs-60 -lm -L"/usr/local/lib/erlang/lib/erl_interface-3.10.2.2/lib" -lerl_interface -lei -o priv/couchjs)
failed with return code 1 and the following output:
/usr/bin/ld: priv/couch_js/60/main.o: undefined reference to symbol '_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3'
//usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
```
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
make, and make check in RHEL
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [X] Code is written and works correctly
- [X] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jiangphcn merged pull request #3057: fixup: Build couch_js for redhat linux
Posted by GitBox <gi...@apache.org>.
jiangphcn merged pull request #3057:
URL: https://github.com/apache/couchdb/pull/3057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jiangphcn commented on a change in pull request #3057: fixup: Build couch_js for redhat linux
Posted by GitBox <gi...@apache.org>.
jiangphcn commented on a change in pull request #3057:
URL: https://github.com/apache/couchdb/pull/3057#discussion_r466178559
##########
File path: src/couch/rebar.config.script
##########
@@ -118,6 +118,11 @@ end,
"-DXP_UNIX -I/usr/include/mozjs-60 -I/usr/local/include/mozjs-60 -std=c++14",
"-L/usr/local/lib -lmozjs-60 -lm -std=c++14 -lc++"
};
+ {unix, linux} when SMVsn == "60" ->
Review comment:
@wohali thanks for your question and suggestion. I tested with Centos and Debian, and it will not break if we just add -lstdc++ to the {unix, _} case. I change accordingly. Could you please check again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on a change in pull request #3057: fixup: Build couch_js for redhat linux
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #3057:
URL: https://github.com/apache/couchdb/pull/3057#discussion_r465813973
##########
File path: src/couch/rebar.config.script
##########
@@ -118,6 +118,11 @@ end,
"-DXP_UNIX -I/usr/include/mozjs-60 -I/usr/local/include/mozjs-60 -std=c++14",
"-L/usr/local/lib -lmozjs-60 -lm -std=c++14 -lc++"
};
+ {unix, linux} when SMVsn == "60" ->
Review comment:
@jiangphcn thanks for this, what happens if we just add `-lstdc++` to the `{unix, _}` case? Does it break other Linux builds? Or, is there a reason the `-std=c++14` line won't work on RHEL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org