You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/27 08:29:17 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

HeartSaVioR commented on pull request #27664:
URL: https://github.com/apache/spark/pull/27664#issuecomment-619819838


   I'm sorry, but I think the name of the method should represent the thing what it does. That's why the boolean parameters have been considered as code smell and even we encourage to specify the name of boolean parameter while calling the method.
   
   We may be able to try deduplicating the code via allowing some additional call on `exists` - so `getLatest()` can be implemented as a combination of `getLatestBatchId()` and `get()`. Does it make sense?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org