You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/08 16:43:55 UTC
[GitHub] [flink] twalthr commented on a change in pull request #10606:
[FLINK-15009][table-common] Add a utility for creating type inference logic
via reflection
twalthr commented on a change in pull request #10606: [FLINK-15009][table-common] Add a utility for creating type inference logic via reflection
URL: https://github.com/apache/flink/pull/10606#discussion_r364331117
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/utils/ExtractionUtils.java
##########
@@ -565,6 +661,181 @@ public void visitLocalVariable(
}
}
+ // --------------------------------------------------------------------------------------------
+ // Class Assignment and Boxing
+ //
+ // copied from o.a.commons.lang3.ClassUtils (commons-lang3:3.3.2)
Review comment:
Because I don't like to add a dependency to `flink-table-common` for a simple util function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services